Create a new postgres configuration secret when restoring a new instance#1733
Merged
rooftopcellist merged 1 commit intoansible:develfrom Mar 11, 2024
Merged
Conversation
- This will avoid the operator changing the host value of the original deployments postgres_configuration_secret. As it was, restores broke the original deployment if it was still around before this change. Signed-off-by: Christian M. Adams <chadams@redhat.com>
dsavineau
approved these changes
Mar 8, 2024
TheRealHaoLiu
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prior to this PR, when restoring:
awx-1-postgres-13-->awx-2-postgres-13. This results in the second deployment working, but the first deployment failing because it cannot reach the database.The user has a working deployment from the restore at this point, so they can safely delete the initial deployment. It is a bug that the initial deployment is broken in the process, but the user is left with a working deployment.
ISSUE TYPE
ADDITIONAL INFORMATION
Expected Behavior
The restore role attempts to inject the new host name for postgres into the existing secret.
This is the desired behavior if the name of the deployment is the same as the original deployment.
However, if the
deployment_nameis different (as we advise customers to do), the restore role should create a new secret with the new host name.Verification Details
After this change, the host and secret name are set appropriately for the new deployment.
After restoring, I am able to log in to my instance with a user from the old instance.