Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ansible/awx-operator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.16.0
Choose a base ref
...
head repository: ansible/awx-operator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.16.1
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 30, 2024

  1. Add explicit list filter after rejectattr (#1845) 

    With ansible 2.9.27 (operator-sdk v1.27.0) then the rejectattr filter
returns a generator so we need to cast it to list.
The behavior doesn't exist when using a more recent operator-sdk
version like v1.34.0 (ansible-core 2.15.8) but using the list
filter on that version works too (even if not needed)

"<generator object select_or_reject at 0x7fbbf0443728>"

This is a similar issue as 80a9e8c.

TASK [Get the new resource pod information after updating resource.]
********************************
FAILED! => {"msg": "The conditional check '_new_pod['resources'] | rejectattr('metadata.deletionTimestamp', 'defined') | length' failed.
The error was: Unexpected templating type error occurred on ({% if _new_pod['resources'] | rejectattr('metadata.deletionTimestamp', 'defined') | length %} True {% else %} False {% endif %}): object of type 'generator' has no len()

This also removes the unneeded quotes on the when conditions.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
    @dsavineau
    dsavineau authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ed72dc1 View commit details
    Browse the repository at this point in the history
Loading