Skip to content

Discover Flatcar Linux properly for hostname#69627

Merged
Akasurde merged 1 commit intoansible:develfrom
kinvolk:dongsu/distro-flatcar
Jun 2, 2020
Merged

Discover Flatcar Linux properly for hostname#69627
Akasurde merged 1 commit intoansible:develfrom
kinvolk:dongsu/distro-flatcar

Conversation

@dongsupark
Copy link
Copy Markdown

SUMMARY

To avoid issues with Flatcar Container Linux being unable to be found,
detect Flatcar distro name especially for hostname, just like CoreOS
Container Linux was supported.

Fixes #69516

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels May 20, 2020
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 20, 2020
@ansibot
Copy link
Copy Markdown
Contributor

ansibot commented May 20, 2020

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/units/module_utils/test_distribution_version.py:1105:161: E501: line too long (222 > 160 characters)
test/units/module_utils/test_distribution_version.py:1108:161: E501: line too long (200 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. labels May 20, 2020
@Akasurde Akasurde self-assigned this May 21, 2020
Copy link
Copy Markdown
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a change log entry for this change? Rest LGTM

@dongsupark
Copy link
Copy Markdown
Author

@Akasurde I have added a changelog entry.
Thanks for the review.

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label May 22, 2020
@Akasurde Akasurde requested review from Akasurde and samdoran May 26, 2020 15:04
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label May 26, 2020
To avoid issues with Flatcar Container Linux being unable to be found,
detect Flatcar distro name especially for hostname, just like CoreOS
Container Linux was supported.

See also #69516
@dongsupark
Copy link
Copy Markdown
Author

Rebased, and adapted its unit test for the new test format.

@Akasurde Akasurde merged commit 598e339 into ansible:devel Jun 2, 2020
@Akasurde
Copy link
Copy Markdown
Member

Akasurde commented Jun 2, 2020

@dongsupark Thanks for the contribution.

@dongsupark dongsupark deleted the dongsu/distro-flatcar branch June 2, 2020 13:54
@ansible ansible locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flatcar Container Linux not properly discovered

4 participants