Conversation
- Added a bunch of tests for mouse parsing - Fixed the missing motion/drag detection causing issue in #661 I did not test the 661 in a X11 env since i'm on wayland, lets see if reporter can confirm the fix otherwise i can try in a VM later
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
Collaborator
|
Could it break existing behavior? |
kommander
approved these changes
Feb 11, 2026
Collaborator
Author
The current implementation actually is broken. Since we didn’t parse the bit it gets interpreted as down event. Most terminals support the other mode so this issue isn’t noticed unless you have x11 and use urxvt or something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not test the 661 in a X11 env since i'm on wayland, lets see if reporter
can confirm the fix otherwise i can try in a VM later