-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add favorites to model selector (#23) #4343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favorites to model selector (#23) #4343
Conversation
* adding favorite model picker
|
@rekram1-node - please review when you have a chance! |
16aed1b to
3b005d2
Compare
917250b to
f4593c6
Compare
f1dc981 to
3e15a39
Compare
df8bdf9 to
0dd5039
Compare
|
The logic for rendering favorites also doesnt really seem to work amazing? I favorite a model and it doesnt show up in favorites |
|
Also if something was your "favorite" wouldn't it act as a pin? So it'd be at the top? Idk that could be more natural prolly |
how would you like favorites vs recents to show up? if a model is both a favorite and a recent (which is going to be the case most of the time), should it show up twice, in both of the top 2 sections all the time? I thought it would be better to deduplicate and show recent favorites just in the recent list, but still indicated with a star. if you have a better idea, i'm all ears |
@rekram1-node |
|
@rekram1-node how does this look? When currently selected model is a favorite:
When currently selected model is not a favorite:
|
…rite recents, instead of counting the favorites against the recents if a model is both
c6e3cbc to
13b2839
Compare




Introduce model favorites across in TUI with grouping, bookmarking (ctrl+f), and cycle keybinds; update config, SDKs, and docs.
SelectDialog(packages/ui/src/components/select-dialog.tsx) addsonKeyEventto handle custom keyboard actions and passes the currently selected item.local.model(packages/desktop/src/context/local.tsx) addsfavoritespersistence (localStorage),favorite()getter, andtoggleFavorite().local.model(packages/opencode/src/cli/cmd/tui/context/local.tsx) adds persistentfavoritelist (saved tomodel.json),favorite(),toggleFavorite(), andcycleFavorite()with recent list updates and validation/toasts.packages/opencode/src/cli/cmd/tui/app.tsx) adds actions for cycling favorite models forward/reverse.packages/opencode/src/cli/cmd/tui/component/dialog-model.tsx) shows Favorites section, stars for favorites, orders recents with current first, hides duplicates, and supportsctrl+fto toggle favorite.model_cycle_favoriteandmodel_cycle_favorite_reverseinpackages/opencode/src/config/config.ts, surfaced in SDKs (Go/TS/Python) and docs (web/docs/keybinds.mdx).