feat(ACP): integrate ACP permission handling into session prompt#3336
Merged
rekram1-node merged 3 commits intoOct 24, 2025
Merged
Conversation
4d79cd4 to
c18bdc4
Compare
This was referenced Oct 21, 2025
566aa8d to
368b73b
Compare
Collaborator
|
ill take a look at this today, thanks! |
Collaborator
|
merge conflict now :/ I think I am gonna try to reorganize the acp stuff I dont want it to be so coupled to the core logic if we can help it |
Contributor
Author
|
@rekram1-node Do you tend to refactor ACP in this PR or create a new PR after this one is merged? |
Collaborator
|
if you resolve the merge conflicts I will merge the pr, either to a refactor branch or directly but your name will be on the changes at the end of it all either way :) |
368b73b to
dca9653
Compare
Contributor
Author
|
Code conflict resolved. |
Closed
43c194d to
6a2b5fb
Compare
Collaborator
|
merged into my cleanup branch, will prolly have something cleaned up and shipped tmr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
askpermision hang when invoked #3332Testing