fix(app): restore file tree, terminal and search buttons in V2 layout#32285
Closed
luoweilin-pbc wants to merge 1 commit into
Closed
fix(app): restore file tree, terminal and search buttons in V2 layout#32285luoweilin-pbc wants to merge 1 commit into
luoweilin-pbc wants to merge 1 commit into
Conversation
Fixes two bugs in session-header.tsx:
1. The Show when={isV2} gate passed a function reference (always
truthy) instead of calling isV2(), so the old layout fallback
was NEVER rendered. Settings > 'New layout designs' had no effect.
2. SessionHeaderV2Actions lacked buttons for file tree, terminal,
and search even when their visibility settings were enabled.
Added them with proper tooltips and pressed states.
Also added terminal and file-tree icons to the V2 icon set.
Fixes anomalyco#29951
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in
session-header.tsx:isV2gate broken:Show when={isV2}passed a function reference (always truthy) instead of callingisV2(). The old layout fallback was never rendered — Settings > 'New layout designs' had no effect.Missing V2 buttons:
SessionHeaderV2Actionslacked buttons for file tree, terminal, and search even when their visibility settings were enabled. Added them with proper tooltips, pressed states, and aria attributes.Also added
terminalandfile-treeSVG icons to the V2 icon set.Fixes #29951