fix(mcp): refresh prompt slash commands#32129
Open
rekram1-node wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28579
Related to #28567
Type of change
What does this PR do?
MCP prompts are part of the cached command catalog. When an MCP server connects after that cache is initialized, disconnects, is replaced, or sends
notifications/prompts/list_changed, the slash-command list can remain stale.This adds a prompt catalog invalidation flow that publishes an MCP catalog event when prompt availability may have changed, rebuilds the command catalog, publishes
command.changed, and refreshes command state in the app and TUI clients. Notifications from disconnected or replaced clients are ignored, and the notification handler is registered only when the server advertisesprompts.listChanged.Command refresh failures are handled so event-driven refreshes do not create unhandled promise rejections.
How did you verify your code works?
command.changed.bun test test/mcp/lifecycle.test.tsinpackages/opencode(33passing).bun test src/context/global-sync/event-reducer.test.tsinpackages/app(15passing).bun typecheckinpackages/opencode,packages/app, andpackages/tui.Screenshots / recordings
Not applicable.
Checklist