fix(app): restore device attachment picker#31707
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31706
Type of change
What does this PR do?
Restores the prompt composer
+button to always use the device/native attachment picker instead of switching remote servers to the workspace file picker.Before this change, remote/non-local sessions opened
DialogSelectFile mode="files", so mobile web users could not use the+button to attach screenshots, photos, PDFs, or text files from their device. That behavior appears to have been added for WSL server files, but later applied to all non-local servers.This removes the remote server picker branch, keeps the existing native desktop picker support, and falls back to the hidden browser file input on web/mobile. It also removes the now-unused server attachment conversion helper and the
DialogSelectFile.onSelectFileselection-only API that was only used by this flow.How did you verify your code works?
cd packages/app && bun typecheckcd packages/app && bun test --preload ./happydom.ts ./src/components/prompt-input/attachments.test.tsgit diff --checkScreenshots / recordings
N/A
Checklist