fix(opencode): agent variant configuration from opencode.json(c) not considered#28709
Open
Arjith8 wants to merge 7 commits into
Open
fix(opencode): agent variant configuration from opencode.json(c) not considered#28709Arjith8 wants to merge 7 commits into
Arjith8 wants to merge 7 commits into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
There were some type issues unrelated to my change so i did use --no-verify flag when pushing, also this should fix #25026 as well |
didnt realize I made this oversight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27790
Closes #28803
Fixes #27790
Type of change
What does this PR do?
The PR fixes the bug where agent config variant mentioned in opencode json isnt considered only the most recent model variant is used. This is wrong behaviour with respect to the expected behaviour from https://opencode.ai/config.json check AgentConfig -> properties -> variant -> description. I could have sworn I had seen this in docs too, no idea why I cant seem to find it rn
How did you verify your code works?
I have attached recording for the same below
Screenshots / recordings
output.mp4
Checklist
If you do not follow this template your PR will be automatically rejected.