feat(opencode): require session ids for tool definitions#17331
Closed
ian-pascoe wants to merge 1 commit into
Closed
feat(opencode): require session ids for tool definitions#17331ian-pascoe wants to merge 1 commit into
ian-pascoe wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
72ccae7 to
7bd3fa0
Compare
7bd3fa0 to
c5d6b29
Compare
This was referenced Mar 17, 2026
Collaborator
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17334
Type of change
What does this PR do?
tool.definitionhooks now receive the activesessionIDeverywhere tool definitions are built.This changes
ToolRegistry.tools(...)to require session context, threads that through prompt resolution, batch execution, debug agent tool listing, and/experimental/tool, and updates the plugin and SDK contracts to match. It also adds regression coverage for the registry, prompt, debug, and server paths so the hook sees the same session-backed context in each entry point.How did you verify your code works?
bun test test/tool test/serverbun typecheck./packages/sdk/js/script/build.tsgit push -u ian-pascoe feat/tool-definition-session-id(repo hook ran the workspace typecheck successfully)Screenshots / recordings
Not a UI change.
Checklist