fix(desktop): pass credentials when checking default server health on startup#16125
Closed
DaneelOlivaw1 wants to merge 7 commits into
Closed
fix(desktop): pass credentials when checking default server health on startup#16125DaneelOlivaw1 wants to merge 7 commits into
DaneelOlivaw1 wants to merge 7 commits into
Conversation
… startup - Store full server config (url + username + password) instead of just URL - Pass credentials to checkHealthOrAskRetry during startup - Update frontend to save complete server config when setting default - Add backward compatibility for existing URL-only storage Fixes anomalyco#16123
added 6 commits
March 5, 2026 15:16
- Update entry.tsx to serialize/deserialize DefaultServerConfig - Fix useDefaultServerKey to handle DefaultServerConfig type - Maintain backward compatibility with string-only storage
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #16123
Type of change
What does this PR do?
When a remote server with authentication is set as default, the desktop app fails to connect on startup. The root cause is that
checkHealthOrAskRetry()doesn't pass credentials tocheckHealth(), causing authentication to fail.This PR fixes the issue by:
checkHealthOrAskRetry()to accept and pass credentialsHow did you verify your code works?
The fix ensures that when a default server with authentication is configured:
Backward compatibility is maintained - existing users with URL-only storage will continue to work (credentials will be optional).
Checklist