fix(session): stop loop when model returns non-tool finish reason#11152
Closed
tremo1 wants to merge 1 commit into
Closed
fix(session): stop loop when model returns non-tool finish reason#11152tremo1 wants to merge 1 commit into
tremo1 wants to merge 1 commit into
Conversation
When the model returns a response with finish_reason other than "tool-calls" or "unknown" (e.g. "stop"), the processor was returning "continue" which caused the main loop to keep running. This led to repeated API calls with identical messages. Now the processor correctly returns "stop" when the model indicates it's done, breaking the loop as expected.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11153
When the model returns finish_reason=stop, the processor was returning "continue" causing repeated API calls with identical messages.
Change: Return "stop" from processor when finish reason is not "tool-calls" or "unknown".
Verification: Traced through logs from a stuck session - model returned finish_reason=stop but processor returned "continue", loop kept running. With this fix, processor returns "stop" and loop breaks.