Add Unit type
#65
Merged
Add Unit type
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 95.00% 94.93% -0.07%
==========================================
Files 2 2
Lines 220 217 -3
Branches 33 41 +8
==========================================
- Hits 209 206 -3
+ Misses 9 2 -7
- Partials 2 9 +7 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
renamed to |
Contributor
Author
Contributor
Author
|
friendly ping |
Zac-HD
approved these changes
Apr 22, 2024
Member
Zac-HD
left a comment
There was a problem hiding this comment.
Thanks for the ping @tlambert03 - this looks good to me, and since we've had no other objections I'm going to go ahead and merge 🙂
Contributor
Author
|
@adriangb, if you're not waiting for other issues to resolve first, could I trouble you for a release on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Unittype (for discussion, see #64).examples:
annotated_types makes no attempt to parse the unit string