Correct misstatement in README #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 94.76% 94.93% +0.16%
==========================================
Files 2 2
Lines 210 217 +7
Branches 30 32 +2
==========================================
+ Hits 199 206 +7
Misses 9 9
Partials 2 2 ☔ View full report in Codecov by Sentry. |
adriangb
reviewed
Feb 22, 2024
| if getattr(self.func, "__name__", "<lambda>") == "<lambda>": | ||
| return f"{self.__class__.__name__}({self.func!r})" | ||
| if isinstance(self.func, (types.MethodType, types.BuiltinMethodType)) and ( | ||
| namespace := getattr(self.func.__self__, "__name__", None) |
Contributor
There was a problem hiding this comment.
Does this work on all Python versions we support now (3.8, so I think yes). Either way this is complex enough to warrant testing, is there a test that hits this or can you add one?
Member
Author
There was a problem hiding this comment.
Yep, it's extracted from a more-complex version in Hypothesis - I'm very confident that it works, and have added a test to make sure it keeps working.
9668619 to
7433413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61, and a typo I spotted.
Following HypothesisWorks/hypothesis#3891 (comment), I've also defined
Predicate.__repr__, so that we see e.g.Predicate(str.isascii)instead ofPredicate(func=<method 'isascii' of 'str' objects>)in error messages.