Add browse_server setting, allows for separate api/web client endpoints.#613
Merged
ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom May 6, 2023
Merged
Add browse_server setting, allows for separate api/web client endpoints.#613ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom
browse_server setting, allows for separate api/web client endpoints.#613ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom
Conversation
… function * Add viper config option `browse_server` to be able to modify the generated `browse` URLs * This is useful if the API endpoint is different from the web client
ankitpokhrel
approved these changes
May 6, 2023
Owner
ankitpokhrel
left a comment
There was a problem hiding this comment.
This works great, thank you @markhatch 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At my company, the on-prem installation has a different API endpoint from the web client endpoint.
This change allows "browse" URLs to point to a different base URL.
#604
API server: jira-api.example.com
UI server: jira.example.com
Changes:
Consolidate all browse URLs to use common GenerateServerBrowseURL function.
Add viper config option
browse_serverto be able to modify the generated browse URLs.Tested by adding
browse_serverto~/.config/.jira/.config.yml