Skip to content

feat: allow setting of fixed columns in the list of issues, epics and sprints#509

Merged
ankitpokhrel merged 1 commit intoankitpokhrel:mainfrom
martinpovolny:issues_fixed_columns
Dec 8, 2022
Merged

feat: allow setting of fixed columns in the list of issues, epics and sprints#509
ankitpokhrel merged 1 commit intoankitpokhrel:mainfrom
martinpovolny:issues_fixed_columns

Conversation

@martinpovolny
Copy link
Contributor

@martinpovolny martinpovolny commented Nov 27, 2022 •
edited
Loading

Allow setting the number of locked (not scrolling) columns in the issue list, epic list and sprint list.

You can do e.g.:

jira issues list -s~Closed --fixed-columns 2

And the "Type" and "KEY" columns will not disappear as you press the right arrow.

@martinpovolny martinpovolny force-pushed the issues_fixed_columns branch 2 times, most recently from 40e734a to 924e52d Compare November 27, 2022 17:24
@martinpovolny martinpovolny changed the title Issues fixed columns feat: allow setting of fixed columns in the list of issues Nov 28, 2022
ankitpokhrel
ankitpokhrel reviewed Dec 3, 2022
View reviewed changes
Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinpovolny, I like this idea but I think this needs a bit of work before we can merge.

The flag fixed-columns should be available and have same behavior across all interactive table listings. For instance, these commands should also behave in the same way as jira issue list --fixed-columns 2

$ jira epic list --table --fixed-columns 2
$ jira epic list <ID> --fixed-columns 2
$ jira sprint list --current --fixed-columns 2
$ jira sprint list <ID> --fixed-columns 2

(Also, I rebased this branch)

@martinpovolny martinpovolny changed the title feat: allow setting of fixed columns in the list of issues feat: allow setting of fixed columns in the list of issues, epics and sprints Dec 3, 2022
@martinpovolny
Copy link
Contributor Author

martinpovolny commented Dec 3, 2022

@ankitpokhrel : Updated as you requested.

Thx for the review!

@ankitpokhrel
Copy link
Owner

ankitpokhrel commented Dec 4, 2022

Hi @martinpovolny thanks!

I noticed slightly different behavior in explorer view for jira epic list, the fixed-columns option doesn't seem to work there. jira sprint list works as expected with fixed-columns tho. Could you please fix this inconsistency, looks good otherwise.

@martinpovolny
Copy link
Contributor Author

martinpovolny commented Dec 4, 2022 •
edited
Loading

Yes! Good find! The epic explorer view did not respect the new option.

e.g.
jira epic list --fixed-columns=2 --project APPSRE

now works as expected.

ankitpokhrel
ankitpokhrel approved these changes Dec 8, 2022
View reviewed changes
Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @martinpovolny!

@ankitpokhrel ankitpokhrel merged commit 86a354b into ankitpokhrel:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitpokhrel ankitpokhrel ankitpokhrel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinpovolny @ankitpokhrel