Add support for OS keyrings/-chains#348
Merged
ankitpokhrel merged 3 commits intoankitpokhrel:mainfrom Apr 26, 2022
Merged
Conversation
Owner
ankitpokhrel
left a comment
There was a problem hiding this comment.
Hi @boyvanamstel, Thank you for working on this feature. I don't have a windows machine to test this either but it seem to be working fine on macOS.
I added one small comment, looks good otherwise. Also, please don't forget to run go mod tidy.
Co-authored-by: Ankit Pokhrel <ankitpokhrel@gmail.com>
Contributor
Author
|
Thanks for the suggestions @ankitpokhrel. Have a look at the new commits. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #247
Notice: Only tested on macOS.