Skip to content

Minor fix: display correctly columns in list sprint command help#320

Merged
ankitpokhrel merged 1 commit intoankitpokhrel:mainfrom
adolsalamanca:minor/fix-issue-263
Mar 12, 2022
Merged

Minor fix: display correctly columns in list sprint command help#320
ankitpokhrel merged 1 commit intoankitpokhrel:mainfrom
adolsalamanca:minor/fix-issue-263

Conversation

@adolsalamanca
Copy link
Contributor

@adolsalamanca adolsalamanca commented Mar 6, 2022

Description

This is a small fix to display correctly possible columns to be passed to List Sprint command as noted in the issue below:
#263

@adolsalamanca adolsalamanca changed the title Minor/ fix possible columns in list sprint command help Minor fix: display correctly columns in list sprint command help Mar 6, 2022
@adolsalamanca
Copy link
Contributor Author

Hey @ankitpokhrel, just converted a few sprint methods to funcs as it was recognized as a smell from deepsource.

Feel free to remove the commit, I understand that even though we are not referencing receiver in methods the behavior could be seen as something specific from the Sprint entity, I just wanted to leave the CI green.

Thanks and regards my friend! :)

@ankitpokhrel
Copy link
Owner

Hi @adolsalamanca Thank you so much for working on this 🙌🏻

I think there is some confusion because of the way this command works. There are 2 types of list that jira sprint command handles.

  1. jira sprint list --table: This displays list of available sprints. The --columns you see in the help is for this listing and is valid.
  2. jira sprint list <SPRINT_ID>: This displays issues within the given sprint. The also supports the same --columns flag but the help file doesn't mention it. (source of confusion)

We can try to make this clear in the help like in the screenshot below. Hopefully that will help to avoid confusion.

Screen Shot 2022-03-06 at 8 50 01 PM

@adolsalamanca
Copy link
Contributor Author

Ohh this was way smaller than I thought, thanks for reviewing @ankitpokhrel , let me know if that was it :)

Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you Adol :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants