Skip to content

feature: Append label to an issue, show labels at issue list view. #300

Merged
ankitpokhrel merged 8 commits intoankitpokhrel:mainfrom
stchar:append-lables
Mar 5, 2022
Merged

feature: Append label to an issue, show labels at issue list view. #300
ankitpokhrel merged 8 commits intoankitpokhrel:mainfrom
stchar:append-lables

Conversation

@stchar
Copy link
Contributor

@stchar stchar commented Feb 16, 2022

Sometimes I just need to add a new label to an issue, unfortunately jira issue edit is designed to overwrite them.

Another miss is if I want to get the labels I need to open the browser or call jira issue view

jira issue edit -lLABUG --label-append

@ankitpokhrel
Copy link
Owner

Hi @stchar, Thank you for the PR.

I can agree that the default behavior for label edit should be to append the labels so that we won't accidentally lose the data. But, Instead of introducing a new flag label-append, I would go with changing the current behavior of the flag label to append the labels instead of overriding them (better than accidentally overriding the data IMO).

Also, let's keep table view as is. We can do a wide variety of things with Jira, and it may not be possible to incorporate everything, and I would like to keep things as simple as possible. A better thing to do would be to make the tool extensible so that devs can add new features on top of the existing one (using plugins).

@stchar
Copy link
Contributor Author

stchar commented Feb 25, 2022

Hi @ankitpokhrel, thanks for the input. I've removed the labels field form the issue view.

Regarding label-append I have a concern that if I change default behavior of -l flag which is now rewrites the label filed. I'll break the backward compatibility.

And people who already use it a lot they may be frustrated. Because they are already ok that it rewrites the field and may have some scripts on top of it. So now its not an architecture miss rather than a feature )) That's why I added additional flag to change the behaviour. What do you think?

@ankitpokhrel
Copy link
Owner

@stchar that's a valid concern, but we are still in v0, and as per semantic versioning, that's acceptable. Be assured that we won't have any breaking change once we reach v1.

From the doc

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@stchar
Copy link
Contributor Author

stchar commented Feb 27, 2022

@ankitpokhrel, ok cool, will rework it.

@stchar
Copy link
Contributor Author

stchar commented Feb 27, 2022

@ankitpokhrel, it's done.

Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stchar Just one small comment, looks good otherwise. Thank you!

@stchar
Copy link
Contributor Author

stchar commented Feb 28, 2022

@ankitpokhrel, cannot see your comments. Did you submit the review?

@ankitpokhrel ankitpokhrel merged commit 0074acd into ankitpokhrel:main Mar 5, 2022
@ankitpokhrel ankitpokhrel added this to the v1.0.0 milestone Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants