Skip to content

Update Gradle Wrapper from 6.8.3 to 7.4.2#171

Closed
github-actions[bot] wants to merge 3 commits intomainfrom
gradlew-update-7.4.2
Closed

Update Gradle Wrapper from 6.8.3 to 7.4.2#171
github-actions[bot] wants to merge 3 commits intomainfrom
gradlew-update-7.4.2

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Apr 7, 2022

Update Gradle Wrapper from 6.8.3 to 7.4.2.

Read the release notes: https://docs.gradle.org/7.4.2/release-notes.html


The checksums of the Wrapper JAR and the distribution binary have been successfully verified.

  • Gradle release: 7.4.2
  • Distribution (-bin) zip checksum: 29e49b10984e585d8118b7d0bc452f944e386458df27371b49b4ac1dec4b7fda
  • Wrapper JAR Checksum: 575098db54a998ff1c6770b352c3b16766c09848bee7555dab09afc34e8cf590

You can find the reference checksum values at https://gradle.org/release-checksums/


🤖 This PR has been created by the Update Gradle Wrapper action.

Need help? 🤔

If something doesn't look right with this PR please file an issue here.

@github-actions github-actions bot added the gradle-wrapper Pull requests that update Gradle wrapper label Apr 7, 2022
@mikehardy mikehardy closed this Apr 7, 2022
@mikehardy mikehardy reopened this Apr 7, 2022
@mikehardy
Copy link
Copy Markdown
Member

Apparently we have to close these and reopen these in order to run CI but it's still better than nothing...

@mikehardy mikehardy mentioned this pull request Apr 7, 2022
@mikehardy mikehardy force-pushed the gradlew-update-7.4.2 branch from 09f5228 to d2adae8 Compare April 8, 2022 02:08
@mikehardy
Copy link
Copy Markdown
Member

mikehardy commented Apr 8, 2022

I recognize the trick being played on gradle with the command line removal of targets from the gradle task dependencies in order to speed things up and hand off the jar artifact from one step to the other - I remembered (after a little while) watching it / maybe discussing it? while it was implemented to speed up CI and builds

Kept the spirit of it but had to alter which targets we -x'd out of the build so that gradle 7 would execute

@mikehardy
Copy link
Copy Markdown
Member

mikehardy commented Apr 8, 2022

I'll continue looking at this, it's close:

net.ankiweb.CollectionCreationTest > ensureCollectionCreatedIsValid FAILED
    java.lang.IllegalStateException at CollectionCreationTest.java:33

That wasn't happening locally, and why not? But it happens for linux and windows

On mac the failure is because I need to -x out that prebuild step too I think - unsure but I can track it down with some time:

> Task :rsdroid-testing:preBuildMac FAILED

This is close though, the major part of the forward-port was passed I think

mikehardy and others added 3 commits April 21, 2022 17:26
so exclude the really expensive tasks but leave jar in for rsdroid:test targets
Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
@mikehardy
Copy link
Copy Markdown
Member

🤔

net.ankiweb.CollectionCreationTest > ensureCollectionCreatedIsValid FAILED
    java.lang.IllegalStateException at CollectionCreationTest.java:33

...but no indication why (yet)

@mikehardy
Copy link
Copy Markdown
Member

Handled in #294

@mikehardy mikehardy closed this Aug 24, 2023
@mikehardy mikehardy deleted the gradlew-update-7.4.2 branch August 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gradle-wrapper Pull requests that update Gradle wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants