Show options menu & navigation drawer using WebView#6387
Merged
mikehardy merged 8 commits intoankidroid:masterfrom Jun 13, 2020
Merged
Show options menu & navigation drawer using WebView#6387mikehardy merged 8 commits intoankidroid:masterfrom
mikehardy merged 8 commits intoankidroid:masterfrom
Conversation
krmanik
commented
Jun 6, 2020
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java
Member
Author
|
This will be useful if AnkiDroid is in fullscreen, then one can be added to open those menu. |
Member
david-allison
left a comment
There was a problem hiding this comment.
One question, then good to go!
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java
…Android into feature-branch-2
mikehardy
approved these changes
Jun 13, 2020
Member
mikehardy
left a comment
There was a problem hiding this comment.
Pretty soon people will be able to have whatever user interface they want, at least with review :-). LGTM, thanks @infinyte7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
Purpose / Description
Show options menu using JavaScript in WebView when screen is in fullscreen.
This is continuation of #6307
Fixes
Fixes Link to the issues.
Approach
How Has This Been Tested?
Tested on Emulator
<script>tagLearning (optional, can help others)
https://stackoverflow.com/questions/32643310/getactionbar-returns-null-in-actionbar
https://stackoverflow.com/questions/4642914/is-there-a-way-to-determine-if-android-app-is-running-full-screen
Checklist
Please, go through these checks before submitting the PR.
ifstatements)