Skip to content

Added tests for export dialog options#20354

Merged
david-allison merged 1 commit intoankidroid:mainfrom
KT-1114:export-dialogue-tests
Mar 9, 2026
Merged

Added tests for export dialog options#20354
david-allison merged 1 commit intoankidroid:mainfrom
KT-1114:export-dialogue-tests

Conversation

@KT-1114
Copy link
Copy Markdown
Contributor

@KT-1114 KT-1114 commented Feb 22, 2026

Description

Adds tests for export options available on export dialogue for exporting as Anki Collection Package and as Anki Deck Package.

Fixes

Approach

Implemented tests check for the expected visibility and values of the options when user tires to export as Anki Deck or as Anki Collection packages.

How Has This Been Tested?

I modified the default values for the visibility of the options and values for the check boxes in the xml file. Then ran the tests to validate the logic.

Learning (optional, can help others)

I learnt how we can automate test and make sure our that if futures changes do something out of order then we can alert ourselves without the user facing any issue. I learnt that isolated parts can also be checked without depending on parts which a user would need to use while using an actual app.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@KT-1114 KT-1114 marked this pull request as draft February 22, 2026 19:58
@KT-1114 KT-1114 force-pushed the export-dialogue-tests branch from 973b660 to 52bb863 Compare February 22, 2026 20:09
@KT-1114 KT-1114 force-pushed the export-dialogue-tests branch from 52bb863 to 3c27971 Compare February 22, 2026 20:23
@KT-1114 KT-1114 marked this pull request as ready for review February 22, 2026 20:43
@KT-1114
Copy link
Copy Markdown
Contributor Author

KT-1114 commented Feb 22, 2026

Hey sorry for this little mess. At first I forgot to redo the changes I made in order to test the tests and then after finding that my push failed the tests I panicked and pushed without adding the change.

I didn't test all these tests locally as my changes were little and I tested the tests, lesson learnt, will take care of this next time.

Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Mar 4, 2026
@david-allison david-allison added this pull request to the merge queue Mar 9, 2026
Merged via the queue into ankidroid:main with commit 308752e Mar 9, 2026
15 checks passed
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Mar 9, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cleanup]: Add Tests to the code (@NeedsTest)

2 participants