Fix client add then delete item then sync issue#51
Merged
VikashKothary merged 1 commit intoankicommunity:developfrom Dec 23, 2020
Merged
Fix client add then delete item then sync issue#51VikashKothary merged 1 commit intoankicommunity:developfrom
VikashKothary merged 1 commit intoankicommunity:developfrom
Conversation
e65fd56 to
c5b44ea
Compare
deck/card/note item must not been synced to server after client add and delete
c5b44ea to
5e56a2e
Compare
Contributor
Author
|
Since depened PR #49 have merged , resubmit this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deck/card/note item must not been synced to server after client add and delete item. The net effect is the item does not exsit on client, so once synced to server, the server should think this item not been exist!
Note: The pr is about the second commit, once
the first commit "fix:once client items in graves have been remove 47f12cb " which is the pr "Fix: server side graves's usn need not set as -1" #49 have been approved ,the pr then can be reviewed and rebased.