Update dep anki ankirspy to 2.1.36 and fix the requirments file create#47
Merged
VikashKothary merged 1 commit intoankicommunity:developfrom Dec 6, 2020
Merged
Conversation
VikashKothary
requested changes
Nov 15, 2020
Member
VikashKothary
left a comment
There was a problem hiding this comment.
This is great. Just a minor change to the lock script and it'll be good to go.
fix the requirements file create
b3e7511 to
7639329
Compare
upsuper
reviewed
Jan 1, 2021
Comment on lines
+5
to
+6
| echo "THE FILE WAS GENERATED BY POETRY, DO NOT EDIT!\n\n" > src/requirements.txt | ||
| echo "THE FILE WAS GENERATED BY POETRY, DO NOT EDIT!\n\n" > src/requirements-dev.txt |
Contributor
There was a problem hiding this comment.
Hey. I'm not sure what should I expect, but this doesn't seem to work for me with pip 20.0.2 on Python 3.8. When I run pip3 install -r src/requirements.txt it prints:
ERROR: Invalid requirement: 'THE FILE WAS GENERATED BY POETRY, DO NOT EDIT!' (from line 1 of src/requirements.txt)
I suppose this line should be commented like
echo "# THE FILE WAS GENERATED BY POETRY, DO NOT EDIT!\n\n" > src/requirements.txt
echo "# THE FILE WAS GENERATED BY POETRY, DO NOT EDIT!\n\n" > src/requirements-dev.txtinstead?
Member
There was a problem hiding this comment.
Hi @upsuper,
That's a very good point. Those lines should indeed be comments.
Could you possibly create a PR for this fix? If not, I'll try to find some time this weekend to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the requirements file create:
Add comment header to requirements.txt #41
update anki-sync-server version to 2.2.0 in pyproject.toml
update dep anki ankirspy to 2.1.36