Enhance CLI build process and strong-name sign .NET SDK#3
Merged
Conversation
…ation (#1776) * fix(rust): backdate extracted CLI mtime to stop self-invalidation When `bundled-cli` is off, `build.rs` watches the extracted CLI binary via `cargo:rerun-if-changed` so a deleted cache binary forces a re-extract. On a cold cache the same build script *creates* that binary mid-build, after the download — so its mtime ends up newer than cargo's build-script `output` reference (stamped when the script was spawned). The next identical `cargo` invocation then sees the watched file as "changed", reruns build.rs, recompiles the SDK crate, and relinks every downstream crate (observed ~9 min of wasted CI on a second cargo invocation in the same job). Backdate the staged binary's mtime to the Unix epoch before the atomic rename (rename preserves mtime), so it lands unambiguously older than any real build reference and a no-change rebuild stays a true no-op. Best-effort: on error we emit a `cargo:warning` and continue, reverting to the prior redundant-rebuild behaviour rather than breaking the build. The deleted-file recovery contract is untouched — a missing file still can't be stat'd, so cargo still reruns. Embed mode (`bundled-cli` on) is unaffected: it emits no `rerun-if-changed` on any build-created file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(rust): write staging binary through a single file handle Address review: open the staging file once and perform the write, permission-set, and mtime-backdate on one handle instead of reopening it for each step. Write and chmod failures stay fatal; the epoch backdate stays best-effort (warn and continue). Behavior is otherwise unchanged: the extracted binary still lands epoch-dated so a no-change rebuild is a true no-op. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the canonical .NET Open.snk key to strong-name sign the GitHub.Copilot.SDK assembly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for intercepting and handling Copilot LLM inference requests at the client level, allowing custom request handlers to be injected and tested. It also adds several polyfills and downlevel extensions to improve compatibility with .NET Standard 2.0, and includes new end-to-end tests for error and cancellation scenarios in custom LLM inference handlers.
Client LLM Inference Interception and Handler Injection:
Added a new
RequestHandlerproperty toCopilotClientOptions, allowing clients to provide a customCopilotRequestHandlerfor intercepting all LLM inference requests. The client registers this handler globally if set, routing all model-layer HTTP/WebSocket requests through it instead of the runtime's default outbound calls. (dotnet/src/Types.cs,dotnet/src/Client.cs) [1] [2] [3] [4] [5]Implemented the logic in
CopilotClientto build and register these client-global API handlers on connection, and to configure the runtime to use the client-provided LLM inference provider when appropriate. (dotnet/src/Client.cs) [1] [2] [3] [4] [5]Testing and Error Handling Improvements:
CopilotRequestCancelErrorE2ETests) to verify that the client correctly handles thrown errors and cancellation in custom LLM inference request handlers, ensuring that errors are surfaced and cancellations are observed as expected. (dotnet/test/E2E/CopilotRequestCancelErrorE2ETests.cs)Polyfills and Downlevel Extensions for .NET Standard 2.0:
StreamandEncodingto handle span/memory-based read/write and string conversions.HttpContentto provide cancellation support.ValueWebSocketReceiveResultand related extensions forWebSocketto support memory-based send/receive operations. (dotnet/src/Polyfills/DownlevelExtensions.cs) [1] [2]Build and Signing Enhancements:
GitHub.Copilot.SDKassembly by specifying anOpen.snkkey file and enabling assembly signing in the build properties. (dotnet/Directory.Build.props)Process Shutdown and Cleanup Logic:
dotnet/src/Client.cs) [1] [2]These changes enable advanced customization and testing scenarios for Copilot LLM inference, improve cross-platform compatibility, and streamline process management.