Merged
Conversation
--------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
…8629) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
…dfs-fixture (#18645) * Bump com.squareup.okio:okio in /test/fixtures/hdfs-fixture Bumps [com.squareup.okio:okio](https://github.com/square/okio) from 3.13.0 to 3.14.0. - [Release notes](https://github.com/square/okio/releases) - [Changelog](https://github.com/square/okio/blob/master/CHANGELOG.md) - [Commits](square/okio@parent-3.13.0...parent-3.14.0) --- updated-dependencies: - dependency-name: com.squareup.okio:okio dependency-version: 3.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
* Pass aux transport to secure settings parameters(). Signed-off-by: Finn Carroll <carrofin@amazon.com> * Update javadocs, fix UTs. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Spotless apply Signed-off-by: Finn Carroll <carrofin@amazon.com> * Pass aux transport key as unique identifier instead of transport ref. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Consistent naming. auxTransportSettingKey -> auxTransportType. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Changelog. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Spotless apply Signed-off-by: Finn Carroll <carrofin@amazon.com> --------- Signed-off-by: Finn Carroll <carrofin@amazon.com>
* Making snapshot store/restore rate dynamic Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> * simple the code Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
…tribution/packages (#18646) * Bump com.netflix.nebula.ospackage-base in /distribution/packages Bumps com.netflix.nebula.ospackage-base from 11.11.2 to 12.0.0. --- updated-dependencies: - dependency-name: com.netflix.nebula.ospackage-base dependency-version: 12.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
* copied from other branch, ready for pr Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * cleanup from merging Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * another spotless apply and fixed breaking change Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * another spotlessApply Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * forgot to change back concurrent agg stuff Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * forgot to spotless after prev fix Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * added more unit tests for coverage Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changed to supplier, removed timer ctors Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * made feedback changes Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * forgot javadoc for new class Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * forgot to revert name to toString Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * fix count check in concurrentquerypb Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * unmodifiable map add Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> --------- Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> Signed-off-by: TJ Neuenfeldt <56700214+neuenfeldttj@users.noreply.github.com>
… for Regexp queries introduced in OpenSearch 3.0 (#18640) * FIx ~ bug Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
* Fix bug in replication lag computation. This change fixes a bug with replication lag computation to correctly use epoch reference point with Instant.now() and DateUtils. This change also fixes pruning logic to correctly remove the latest synced to checkpoint from tracking. Previously we would only prune up to the latest. This ensures that when a new checkpoint is eventually received we aren't incorrectly computing lag from the synced-to checkpoint. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add changelog entry Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix flaky test to hardcode time lag between checkpoint arrival. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
--------- Signed-off-by: Du Tran <quangdutran809@gmail.com>
…rContext in QueryPhase (#18637) * Initial Commit Signed-off-by: Varun Jain <varunudr@amazon.com> * Javadocs Signed-off-by: Varun Jain <varunudr@amazon.com> * Factory design pattern for QueryCollectorContextSpec Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing Concurrent Segment Search Signed-off-by: Varun Jain <varunudr@amazon.com> * Remove spec Signed-off-by: Varun Jain <varunudr@amazon.com> * Renaming method Signed-off-by: Varun Jain <varunudr@amazon.com> * Javadoc Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing support method from QueryCollectorContextSpecFactory Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding javadoc Signed-off-by: Varun Jain <varunudr@amazon.com> * Add changelog Signed-off-by: Varun Jain <varunudr@amazon.com> * Add experimentalAPI annotation Signed-off-by: Varun Jain <varunudr@amazon.com> * remove redundant check from getQueryCollectorContextSpec method Signed-off-by: Varun Jain <varunudr@amazon.com> * Add unit tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Remove Test annotation Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com>
…/repository-azure (#18644) * Bump com.azure:azure-storage-blob in /plugins/repository-azure Bumps [com.azure:azure-storage-blob](https://github.com/Azure/azure-sdk-for-java) from 12.30.0 to 12.30.1. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.30.0...azure-storage-blob_12.30.1) --- updated-dependencies: - dependency-name: com.azure:azure-storage-blob dependency-version: 12.30.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18636) * Fix checkpoint handling to prevent segment replication infinite loop Signed-off-by: Ashish Singh <ssashish@amazon.com> * Modify existing test to verify code change behaviour Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
* Extend approximation to other numeric types Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix basic tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix basic tests Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add Parameterized tests for all numeric types Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix FieldSortIT Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix FieldSortIT Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Address comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update tests and changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update tests and changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Changes: - Bump org.bouncycastle:bctls-fips from 2.0.19 to 2.0.20 - Bump org.bouncycastle:bcpkix-fips from 2.0.7 to 2.0.8 - Bump org.bouncycastle:bcpg-fips from 2.0.10 to 2.0.11 - Bump com.password4j:password4j from 1.8.2 to 1.8.3 Signed-off-by: Andrey Pleskach <ples@aiven.io>
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
…ileCachedIndexInput (#18662) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…mote store (#18686) Signed-off-by: Gagan Singh Saini <gagasa@amazon.com> Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
* Added support for range version support in semver Signed-off-by: Shruti Garg <shrugarg@amazon.com> * Added test coverage for missing lines Signed-off-by: Shruti Garg <shrugarg@amazon.com> * Fixed for non reachable code line and tests Signed-off-by: Shruti Garg <shrugarg@amazon.com> --------- Signed-off-by: Shruti Garg <shrugarg@amazon.com>
…18680) Signed-off-by: Andriy Redko <drreta@gmail.com>
…dfs-fixture (#18689) * Bump com.squareup.okio:okio in /test/fixtures/hdfs-fixture Bumps [com.squareup.okio:okio](https://github.com/square/okio) from 3.14.0 to 3.15.0. - [Release notes](https://github.com/square/okio/releases) - [Changelog](https://github.com/square/okio/blob/master/CHANGELOG.md) - [Commits](square/okio@parent-3.14.0...parent-3.15.0) --- updated-dependencies: - dependency-name: com.squareup.okio:okio dependency-version: 3.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add Semantic Version field type mapper and extensive unit tests Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Refactor SemanticVersionFieldMapper for flexible index, store, and doc_values support Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
…y-azure (#18691) * Bump com.azure:azure-core in /plugins/repository-azure Bumps [com.azure:azure-core](https://github.com/Azure/azure-sdk-for-java) from 1.55.3 to 1.55.5. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core_1.55.3...azure-core_1.55.5) --- updated-dependencies: - dependency-name: com.azure:azure-core dependency-version: 1.55.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Exposing default codec from codec service Signed-off-by: bharath-techie <bharath78910@gmail.com> * addressing comments Signed-off-by: bharath-techie <bharath78910@gmail.com> --------- Signed-off-by: bharath-techie <bharath78910@gmail.com>
…efault thresholds (#18666) Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* Add Prudhvi Godithi (GH: prudhvigodithi) as a maintainer Signed-off-by: Craig Perkins <cwperx@amazon.com> * Keep spaces Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix spacing Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
…18697) * Fix: Include named queries from rescore contexts in matched_queries array - Modified QueryRescoreContext to store ParsedQuery instead of just Query - Updated QueryRescorerBuilder to use context.toQuery() for capturing named queries - Enhanced MatchedQueriesPhase to collect named queries from all rescore contexts - Added comprehensive tests for both unit and REST API scenarios - Resolves inconsistency with Elasticsearch behavior where rescore named queries were not surfaced - Cleaned up unnecessary comments for better code readability Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> * Address maintainer feedback: update RescoreContext interface design - Added parsedQuery() method to RescoreContext interface - Added getParsedQueries() method to RescoreContext interface - Updated QueryRescoreContext to override interface methods - Removed instanceof check in MatchedQueriesPhase by using interface method - Simplified assignment in QueryRescorerBuilder to one line Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> * Complete interface replacement: replace query() with parsedQuery() and getQueries() with getParsedQueries() - Removed query() method from QueryRescoreContext - Removed getQueries() method from RescoreContext interface - Updated all callers to use parsedQuery().query() instead of query() - Updated DfsPhase to use getParsedQueries() instead of getQueries() - Updated QueryRescorer to use parsedQuery().query() for rescoring and explanations - Updated QueryRescorerBuilderTests to use parsedQuery().query() - This addresses the maintainer's feedback for a cleaner interface design Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> * Finalize interface design and move changelog entry to Added section - Removed parsedQuery() method from RescoreContext base interface - Renamed getParsedQuery() to parsedQuery() in QueryRescoreContext for consistency - Updated all callers to use parsedQuery() method - Moved changelog entry to 'Added' section (more appropriate than 'Fixed') - Added proper imports for ParsedQuery to improve code readability - All tests pass and code formatting is correct Final interface design: - RescoreContext: only getParsedQueries() (returns List<ParsedQuery>) - QueryRescoreContext: parsedQuery() + getParsedQueries() override - MatchedQueriesPhase: uses getParsedQueries().forEach() for clean iteration This addresses all maintainer feedback from @mch2 and provides a clean, well-tested implementation that surfaces named queries from rescore contexts in the matched_queries array. Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> * Maintain backward compatibility for RescoreContext public API - Restore getQueries() method for backward compatibility - Add getParsedQueries() method for new functionality Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> * Fix mixed cluster test failure by updating skip version to 3.2.0 Signed-off-by: girish jeyakumar <girishjeyakumar@dropbox.com> --------- Signed-off-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> Signed-off-by: girish jeyakumar <girishjeyakumar@dropbox.com> Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Co-authored-by: Girish Jeyakumar <girishjeyakumar@dropbox.com> Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
* Some explicit transient gRPC deps are not the expected version. grpc-netty-shaded:1.68.2 expects perfmark-api:0.27.0 guava:33.2.1-jre expects failureaccess:1.0.2 Signed-off-by: Finn Carroll <carrofin@amazon.com> * Update license shas. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Changelog. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Rebase changelog. Signed-off-by: Finn Carroll <carrofin@amazon.com> --------- Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
* Fix max_score is null when sorting on score firstly Signed-off-by: Binlong Gao <gbinlong@amazon.com> * modify changelog Signed-off-by: Binlong Gao <gbinlong@amazon.com> * Fix test failure Signed-off-by: Binlong Gao <gbinlong@amazon.com> --------- Signed-off-by: Binlong Gao <gbinlong@amazon.com>
* Changes for the Upload Workflow for merged segments Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Addressed Todos Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Added Test Cases Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Removed the usage of Forbidden APIs Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Updated the code to include priority upload as paramter Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Updated the remote listener to use remote upploader interface Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Added JavaDocs across the changes Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Addressed spotless check Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Dummy commit(can be reverted) Signed-off-by: Aditi Goyal <adgoyal@amazon.com> * Revert "Dummy commit(can be reverted)" This reverts commit e542b99. Signed-off-by: Aditi Goyal <adgoyal@amazon.com> --------- Signed-off-by: Aditi Goyal <adgoyal@amazon.com> Co-authored-by: Aditi Goyal <adgoyal@amazon.com>
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
* Code Improvement Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Code Improvement with a new method Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
…ns/repository-hdfs (#18745) * Bump org.apache.commons:commons-lang3 in /plugins/repository-hdfs Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ildSrc/src/testKit/thirdPartyAudit/sample_jars (#18744) * Bump org.apache.logging.log4j:log4j-core Bumps org.apache.logging.log4j:log4j-core from 2.25.0 to 2.25.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-version: 2.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ns/repository-azure (#18742) * Bump com.azure:azure-storage-common in /plugins/repository-azure Bumps [com.azure:azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.29.0 to 12.29.1. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.29.0...azure-storage-blob_12.29.1) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-version: 12.29.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <gbinlong@amazon.com>
…s/plugin-cli (#18743) * Bump com.google.jimfs:jimfs in /distribution/tools/plugin-cli Bumps [com.google.jimfs:jimfs](https://github.com/google/jimfs) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <gbinlong@amazon.com>
…8660) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
The `upgrade-cli` tool is deprecated and no longer needed. - Removed: distribution/tools/upgrade-cli - Cleaned up: settings.gradle, distribution/build.gradle - Deleted: distribution/src/bin/opensearch-upgrade(.bat) Signed-off-by: BeomSeogKim <kbs4520@daum.net>
Signed-off-by: Shahbaz Aamir <shahbaz07dbit@gmail.com>
…sterPlugin is loaded (#18479) These are the core changes to allow ClusterPlugins to manage cluster state on behalf of an OpenSearch node. If a "clusterless" ClusterPlugin is loaded, then the node will start up with dummy versions of Discovery and ClusterManagerService, and will load the minimum cluster state required for startup (essentially, the node needs to see itself). From there, the ClusterPlugin can interact with ClusterApplierService to apply some cluster state to the node. (The details of constructing/receiving that cluster state is up to the plugin.) --------- Signed-off-by: Michael Froh <msfroh@apache.org>
…emoval (#18661) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.