Skip to content

Remove timeout on deletion of node#146

Merged
animir merged 1 commit intoanimir:masterfrom
jiddmeye:bugfix/remove_timeout_on_delete
Dec 1, 2021
Merged

Remove timeout on deletion of node#146
animir merged 1 commit intoanimir:masterfrom
jiddmeye:bugfix/remove_timeout_on_delete

Conversation

@jiddmeye
Copy link
Copy Markdown

When using the delete function, I noticed that the timeouts are not cleared. This causes the timeout to be executed even if the item was already deleted. If there is already a new item with the same key in the meantime, that one will be removed.

@animir
Copy link
Copy Markdown
Owner

animir commented Dec 1, 2021

@jiddmeye Great find, thank you!

@animir animir merged commit d0b7302 into animir:master Dec 1, 2021
@animir
Copy link
Copy Markdown
Owner

animir commented Dec 1, 2021

Published in v2.3.6

@shneor521
Copy link
Copy Markdown

I spent many hours understanding the strange behavior of my project (I used 2.3.0). In the end, I discovered that this is exactly the bug I have. I upgraded to 2.3.6, and everything works great!
Thanks to @jiddmeye for the finding and the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants