Adding RatioChangeRate unit #678
Conversation
angularsen
left a comment
There was a problem hiding this comment.
Looks good, but a couple of things I'd like you to consider first.
| @@ -0,0 +1,32 @@ | |||
| { | |||
| "Name": "RatioChangeRate", | |||
| "BaseUnit": "PercentPerSecond", | |||
There was a problem hiding this comment.
I would choose DecimalFractionPerSecond as base unit, to be consistent with Ratio.
You would then have to swap some of the conversion functions and test case values too.
| { | ||
| "Name": "RatioChangeRate", | ||
| "BaseUnit": "PercentPerSecond", | ||
| "XmlDoc": "The quantity of percent flowing per unit of time.", |
There was a problem hiding this comment.
How about The change in ratio per unit of time. ?
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "" ] |
There was a problem hiding this comment.
Hmm.. should this not have an abbreviation? Not sure what, but would perhaps 1/s work? Just something to signify the time dimensions we clearly have.
- Use of DecimalFractionPerSecond as base unit - Correction of the documentation - Adding abbreviation for DecimalFractionPerSecond
|
You are right, I fixed thoses points. I wasn't sure for the abbreviation as a DecimalFraction do not have any. |
|
Nuget on the way out |
No description provided.