Skip to content

Conversation

@fmalcher
Copy link
Member

@fmalcher fmalcher commented Jun 15, 2022

see commit messages for further info!

TODO:

  • docs for the new --project option for ng-add
  • manual validation in Angular 14 project
  • manual validation in older project (for downwards compatibility)

⚠️ Please merge with rebase (no squash) so that the commit history will remain.

resolve #148

fmalcher added 2 commits June 15, 2022 22:39
Starting with NG14 there is no defaultProject setting in angular.json anymore.
With this setting, we can manually select the project that we want to add the deploy config to.
@fmalcher fmalcher requested a review from JohannesHoppe June 15, 2022 21:10
fmalcher added 2 commits June 16, 2022 09:10
Since defaultProject is deprecated, the project must be determined differently. Variants:
- Use the defaultProject if given (for compatibility)
- Use the first project if only one is available
- Use the project defined by the --project arg.
- Throw an error.
@fmalcher fmalcher mentioned this pull request Jun 17, 2022
If you have multiple projects in one workspace, you can manually define the project name:

```sh
ng add angular-cli-ghpages --project MYPROJECTNAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For later, it would be cool if we would have an interactive choice during installation.

@JohannesHoppe JohannesHoppe merged commit 1dc2067 into master Jun 17, 2022
@JohannesHoppe JohannesHoppe deleted the ngadd14 branch June 17, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular 14 support?

3 participants