Skip to content

chore: link workspace packages with pnpm #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesHenry merged 2 commits into from
Aug 26, 2024
Merged

chore: link workspace packages with pnpm #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43539ac
chore: link workspace packages with pnpm
JamesHenry Aug 26, 2024
541cf2e
chore: fix snapshots
JamesHenry Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
link-workspace-packages=true
10 changes: 5 additions & 5 deletions e2e/src/__snapshots__/eslint-8--inline-template-fixer.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ export class TestComponent {}
exports[`eslint-8--inline-template-fixer should generate the expected inline template fixer result 2`] = `
{
"@angular-devkit/build-angular": "^18.X.X",
"@angular-eslint/builder": "18.3.0",
"@angular-eslint/eslint-plugin": "18.3.0",
"@angular-eslint/eslint-plugin-template": "18.3.0",
"@angular-eslint/schematics": "18.3.0",
"@angular-eslint/template-parser": "18.3.0",
"@angular-eslint/builder": "0.0.0-e2e",
"@angular-eslint/eslint-plugin": "0.0.0-e2e",
"@angular-eslint/eslint-plugin-template": "0.0.0-e2e",
"@angular-eslint/schematics": "0.0.0-e2e",
"@angular-eslint/template-parser": "0.0.0-e2e",
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
Expand Down
10 changes: 5 additions & 5 deletions ...shots__/eslint-8--new-workspace-create-application-false-ng-add-then-project.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
exports[`eslint-8--new-workspace-create-application-false-ng-add-then-project should pass linting when running ng-add before creating any projects 1`] = `
{
"@angular-devkit/build-angular": "^18.X.X",
"@angular-eslint/builder": "18.3.0",
"@angular-eslint/eslint-plugin": "18.3.0",
"@angular-eslint/eslint-plugin-template": "18.3.0",
"@angular-eslint/schematics": "18.3.0",
"@angular-eslint/template-parser": "18.3.0",
"@angular-eslint/builder": "0.0.0-e2e",
"@angular-eslint/eslint-plugin": "0.0.0-e2e",
"@angular-eslint/eslint-plugin-template": "0.0.0-e2e",
"@angular-eslint/schematics": "0.0.0-e2e",
"@angular-eslint/template-parser": "0.0.0-e2e",
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
Expand Down
10 changes: 5 additions & 5 deletions ...shots__/eslint-8--new-workspace-create-application-false-project-then-ng-add.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
exports[`eslint-8--new-workspace-create-application-false-project-then-ng-add should pass linting when adding a project before running ng-add 1`] = `
{
"@angular-devkit/build-angular": "^18.X.X",
"@angular-eslint/builder": "18.3.0",
"@angular-eslint/eslint-plugin": "18.3.0",
"@angular-eslint/eslint-plugin-template": "18.3.0",
"@angular-eslint/schematics": "18.3.0",
"@angular-eslint/template-parser": "18.3.0",
"@angular-eslint/builder": "0.0.0-e2e",
"@angular-eslint/eslint-plugin": "0.0.0-e2e",
"@angular-eslint/eslint-plugin-template": "0.0.0-e2e",
"@angular-eslint/schematics": "0.0.0-e2e",
"@angular-eslint/template-parser": "0.0.0-e2e",
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
Expand Down
10 changes: 5 additions & 5 deletions e2e/src/__snapshots__/eslint-8--new-workspace.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
exports[`eslint-8--new-workspace should pass linting after creating a new workspace from scratch using angular-eslint 1`] = `
{
"@angular-devkit/build-angular": "^18.X.X",
"@angular-eslint/builder": "18.3.0",
"@angular-eslint/eslint-plugin": "18.3.0",
"@angular-eslint/eslint-plugin-template": "18.3.0",
"@angular-eslint/schematics": "18.3.0",
"@angular-eslint/template-parser": "18.3.0",
"@angular-eslint/builder": "0.0.0-e2e",
"@angular-eslint/eslint-plugin": "0.0.0-e2e",
"@angular-eslint/eslint-plugin-template": "0.0.0-e2e",
"@angular-eslint/schematics": "0.0.0-e2e",
"@angular-eslint/template-parser": "0.0.0-e2e",
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
Expand Down
6 changes: 3 additions & 3 deletions e2e/src/__snapshots__/inline-template-fixer.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ exports[`inline-template-fixer should generate the expected inline template fixe
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
"angular-eslint": "18.3.0",
"eslint": "^9.9.0",
"angular-eslint": "0.0.0-e2e",
"eslint": "^9.9.1",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.X.X",
"typescript-eslint": "8.1.0"
"typescript-eslint": "8.2.0"
}
`;
6 changes: 3 additions & 3 deletions ...src/__snapshots__/new-workspace-create-application-false-ng-add-then-project.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ exports[`new-workspace-create-application-false-ng-add-then-project should pass
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
"angular-eslint": "18.3.0",
"eslint": "^9.9.0",
"angular-eslint": "0.0.0-e2e",
"eslint": "^9.9.1",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.X.X",
"typescript-eslint": "8.1.0"
"typescript-eslint": "8.2.0"
}
`;

Expand Down
6 changes: 3 additions & 3 deletions ...src/__snapshots__/new-workspace-create-application-false-project-then-ng-add.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ exports[`new-workspace-create-application-false-project-then-ng-add should pass
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
"angular-eslint": "18.3.0",
"eslint": "^9.9.0",
"angular-eslint": "0.0.0-e2e",
"eslint": "^9.9.1",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.X.X",
"typescript-eslint": "8.1.0"
"typescript-eslint": "8.2.0"
}
`;

Expand Down
6 changes: 3 additions & 3 deletions e2e/src/__snapshots__/new-workspace.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ exports[`new-workspace should pass linting after creating a new workspace from s
"@angular/cli": "^18.X.X",
"@angular/compiler-cli": "^18.X.X",
"@types/jasmine": "~5.1.0",
"angular-eslint": "18.3.0",
"eslint": "^9.9.0",
"angular-eslint": "0.0.0-e2e",
"eslint": "^9.9.1",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
Expand All @@ -16,7 +16,7 @@ exports[`new-workspace should pass linting after creating a new workspace from s
"karma-jasmine-html-reporter": "~2.1.0",
"ng-packagr": "^18.X.X",
"typescript": "~5.X.X",
"typescript-eslint": "8.1.0"
"typescript-eslint": "8.2.0"
}
`;

Expand Down
5 changes: 1 addition & 4 deletions nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,7 @@
"release": {
"projects": ["packages/*", "!nx-plugin"],
"version": {
"conventionalCommits": true,
"generatorOptions": {
"installArgs": "--link-workspace-packages"
}
"conventionalCommits": true
},
"changelog": {
"workspaceChangelog": {
Expand Down
Loading