Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

feat(language-service): support to report the deprecated API in the t…#2192

Merged
atscott merged 1 commit intoangular:mainfrom
ivanwonder:support-suggestion-diagnostics
Aug 5, 2025
Merged

feat(language-service): support to report the deprecated API in the t…#2192
atscott merged 1 commit intoangular:mainfrom
ivanwonder:support-suggestion-diagnostics

Conversation

@ivanwonder
Copy link
Copy Markdown
Contributor

@ivanwonder ivanwonder commented Jun 20, 2025

…emplate

In the Typescript Language Service, these diagnostics are reported as suggestion diagnostics. This will report the deprecated Component, Directive, etc.

@ivanwonder
Copy link
Copy Markdown
Contributor Author

ivanwonder commented Jun 20, 2025

Blocked by angular/angular#62054

@ivanwonder ivanwonder marked this pull request as ready for review July 15, 2025 02:57
ivanwonder
ivanwonder commented Jul 15, 2025
View reviewed changes
Comment thread server/src/utils.ts
@ivanwonder
Copy link
Copy Markdown
Contributor Author

ivanwonder commented Jul 15, 2025

@atscott you can review this PR now.

@atscott atscott added target: minor This PR is targeted for the next minor release action: merge Ready to merge labels Jul 15, 2025
@atscott atscott removed the action: merge Ready to merge label Aug 4, 2025
@atscott
Copy link
Copy Markdown
Collaborator

atscott commented Aug 4, 2025

@ivanwonder I am unable to observe this working. Can you describe what this covers now that it's limited to components? Should it support inputs and outputs as well? Should it support inline templates and external templates or just one of the two?

@ivanwonder ivanwonder force-pushed the support-suggestion-diagnostics branch from 3f1522d to 42edee2 Compare August 5, 2025 02:16
@angular-robot angular-robot Bot requested a review from atscott August 5, 2025 02:16
@ivanwonder ivanwonder force-pushed the support-suggestion-diagnostics branch from 42edee2 to 067f7f8 Compare August 5, 2025 02:21
@ivanwonder
feat(language-service): support to report the deprecated API in the t…
729064f 
…emplate

In the Typescript Language Service, these diagnostics are reported as
suggestion diagnostics. This will report the deprecated `Component`,
`Directive`, etc.
@ivanwonder ivanwonder force-pushed the support-suggestion-diagnostics branch from 067f7f8 to 729064f Compare August 5, 2025 02:33
@ivanwonder
Copy link
Copy Markdown
Contributor Author

ivanwonder commented Aug 5, 2025

@ivanwonder I am unable to observe this working. Can you describe what this covers now that it's limited to components? Should it support inputs and outputs as well? Should it support inline templates and external templates or just one of the two?

Sorry, I have not updated the version of the language service. It supports the inline templates and external templates.

You can try again.

@ivanwonder
Copy link
Copy Markdown
Contributor Author

ivanwonder commented Aug 5, 2025

@atscott Just find a bug that will cause the extension to crash.

angular/angular#63002 PTAL.

@atscott
Copy link
Copy Markdown
Collaborator

atscott commented Aug 5, 2025

Sorry, I have not updated the version of the language service. It supports the inline templates and external templates.

Oh, sorry this was actually my mistake. I discovered the extension was broken recently and was waiting on a fix
angular/angular#62811 upstream before testing. When that went in, I updated to 20.1.4 instead of -next to do the test!

@atscott atscott added the action: merge Ready to merge label Aug 5, 2025
@atscott atscott merged commit 69ceb25 into angular:main Aug 5, 2025
4 of 5 checks passed
@ivanwonder ivanwonder deleted the support-suggestion-diagnostics branch August 6, 2025 02:04
@kstrasters-pj
Copy link
Copy Markdown

kstrasters-pj commented Aug 7, 2025

did we really have to mark through the ENTIRE NgForOf block making things unreadable?

image

@atscott atscott mentioned this pull request Aug 7, 2025
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@atscott atscott atscott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge Ready to merge detected: feature target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanwonder @atscott @kstrasters-pj