This repository was archived by the owner on Nov 21, 2025. It is now read-only.
feat(server): support code action#1723
Merged
atscott merged 1 commit intoangular:mainfrom Aug 4, 2022
Merged
Conversation
2 tasks
14 tasks
ce3f9d8 to
d32ae3b
Compare
Contributor
|
@ivanwonder Would you be able to rebase this PR? Let me know if it's time for review on this as well. Thanks! |
d32ae3b to
9a41161
Compare
Contributor
Author
@dylhunn Done. You can review it now. |
atscott
approved these changes
Aug 3, 2022
Collaborator
atscott
left a comment
There was a problem hiding this comment.
LGTM, with a few nits and requests for additional comments. Great work!
In ts service, the `codeFixes`([getCodeFixesAtPosition](https://github.com/microsoft/TypeScript/blob/7584e6aad6b21f7334562bfd9d8c3c80aafed064/src/services/services.ts#L2689)) and refactors([getApplicableRefactors](https://github.com/microsoft/TypeScript/blob/7584e6aad6b21f7334562bfd9d8c3c80aafed064/src/services/services.ts#L2699)) are resolved in different request. But in LSP they are resolved in the `CodeAction` request. Now, this PR only handles the `codeFixes` because the `@angular/language-service` only supports it.
9a41161 to
1674a30
Compare
dylhunn
approved these changes
Aug 4, 2022
atscott
approved these changes
Aug 4, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ts service, the
codeFixes(getCodeFixesAtPosition)and
refactors(getApplicableRefactors)
are resolved in different request. But in LSP they are resolved in the
CodeActionrequest.Now, this PR only handles the
codeFixesbecause the@angular/language-serviceonly supports it.