This repository was archived by the owner on Apr 4, 2025. It is now read-only.
@angular/pwa & SW related fixes/refactorings#999
Closed
gkalpak wants to merge 4 commits intoangular:masterfrom
gkalpak:fix-stuff
Closed
@angular/pwa & SW related fixes/refactorings#999gkalpak wants to merge 4 commits intoangular:masterfrom gkalpak:fix-stuff
gkalpak wants to merge 4 commits intoangular:masterfrom
gkalpak:fix-stuff
Conversation
Contributor
|
Sorry @gkalpak, this got lost when we moved the code back over to the angular/angular-cli repo. Do you have time to re-base this commit on master over there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main fixes are:
package.jsonbaseHref(Fixes ServiceWorker register generated by cli with base-href don't works angular-cli#8515.)
I suspect (1) could be re-used in more places, but I have no idea where/how 😁