ci: allow any command for Renovate post-upgrade tasks#782
Merged
devversion merged 1 commit intoangular:mainfrom Aug 19, 2022
Merged
ci: allow any command for Renovate post-upgrade tasks#782devversion merged 1 commit intoangular:mainfrom
devversion merged 1 commit intoangular:mainfrom
Conversation
The [allowedPostUpgradeCommands][1] pattern list is used to determine whether a [post-upgrade task][2] command is allowed to be run by Renovate. Having to explicitly allow each command creates unnecessary friction. This commit allows any command to be run in a post-upgrade task, which saves us the trouble of having to update the allowed commands pattern list every time we want to add a new post-upgrade task. Since adding/modifying Renovate post-upgrade tasks is subject to the regular PR review workflow, unwanted commands will be caught there. [1]: https://docs.renovatebot.com/self-hosted-configuration/#allowedpostupgradecommands [2]: https://docs.renovatebot.com/configuration-options/#postupgradetasks
devversion
reviewed
Aug 19, 2022
| // See https://github.com/angular/angular/pull/47040. | ||
| '^yarn --cwd=aio/tools/examples/shared run sync-deps$', | ||
| ], | ||
| allowedPostUpgradeCommands: ['.'], |
Member
There was a problem hiding this comment.
Do we want to use .* or something? I don't know if Renovate expects a full match or if a partial is fine.
Member
Author
There was a problem hiding this comment.
No, I don't think Renovate expects a full match. For example, we were using '^yarn run ' before and it worked fine afaict.
devversion
approved these changes
Aug 19, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowedPostUpgradeCommands pattern list is used to determine whether a post-upgrade task command is allowed to be run by Renovate. Having to explicitly allow each command creates unnecessary friction.
This commit allows any command to be run in a post-upgrade task, which saves us the trouble of having to update the allowed commands pattern list every time we want to add a new post-upgrade task.
Since adding/modifying Renovate post-upgrade tasks is subject to the regular PR review workflow, unwanted commands will be caught there.
INFO: Internal discussion