ci: hard-code allowed commands for Renovate post-upgrade tasks#755
Merged
gkalpak merged 1 commit intoangular:mainfrom Aug 4, 2022
Merged
ci: hard-code allowed commands for Renovate post-upgrade tasks#755gkalpak merged 1 commit intoangular:mainfrom
gkalpak merged 1 commit intoangular:mainfrom
Conversation
The [allowedPostUpgradeCommands][1] pattern list is used to determine whether a [post-upgrade task][2] command is allowed to be run by Renovate. Using a regex to try and limit the type of commands that can be run is not a viable strategy. This commit hard-codes the exact command that needs to run for angular.io docs examples dependencies (see angular/angular#47040). Hard-coding commands requires updates in multiple places when a post-upgrade task is added/modified, but adds one more layer of protection against running unwanted commands as part of the Renovate update process. [1]: https://docs.renovatebot.com/self-hosted-configuration/#allowedpostupgradecommands [2]: https://docs.renovatebot.com/configuration-options/#postupgradetasks
devversion
approved these changes
Aug 4, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowedPostUpgradeCommands pattern list is used to determine whether a post-upgrade task command is allowed to be run by Renovate. Using a regex to try and limit the type of commands that can be run is not a viable strategy.
This commit hard-codes the exact command that needs to run for angular.io docs examples dependencies (see angular/angular#47040).
Hard-coding commands requires updates in multiple places when a post-upgrade task is added/modified, but adds one more layer of protection against running unwanted commands as part of the Renovate update process.