refactor: use lightweight token for injecting radio group#19645
Merged
devversion merged 2 commits intoangular:lightweight-token-optimizationsfrom Jun 17, 2020
Merged
Conversation
devversion
commented
Jun 15, 2020
| * alternative token to the actual `MatRadioGroup` class which could cause unnecessary | ||
| * retention of the class and its component metadata. | ||
| */ | ||
| export const MAT_RADIO_GROUP = |
Member
Author
There was a problem hiding this comment.
FYI: This is a separate token in the MDC-based implementation as the non-MDC implementation should not interfere with the MDC-based one.
b75321f to
7716828
Compare
The Angular Material `MatRadioButton` component currently optionally injects the `MatRadioGroup`. This causes the `MatRadioGroup` implementation to be always retained in application bundles. This is problematic as the use of radio groups is not always required. i.e. it's valid to use a standalone radio button. In those cases, we do not want to retain the radio group implementation unnecessarily. This has always been an issue, but the issue became more significant in Ivy where component factory and definitions are attached directly to the `MatRadioGroup` class (resulting in a more significant size increase). We fix this by using a lightweight token for injecting the parent radio group optionally. This solves the retention issue if a standalone radio button is used. Related to: angular#19576.
7716828 to
2c25515
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Angular Material
MatRadioButtoncomponent currently optionallyinjects the
MatRadioGroup. This causes theMatRadioGroupimplementationto be always retained in application bundles.
This is problematic as the use of radio groups is not always required.
i.e. it's valid to use a standalone radio button. In those cases, we do
not want to retain the radio group implementation unnecessarily.
This has always been an issue, but the issue became more significant
in Ivy where component factory and definitions are attached directly
to the
MatRadioGroupclass (resulting in a more significant size increase).We fix this by using a lightweight token for injecting the parent
radio group optionally. This solves the retention issue if a standalone
radio button is used.
Related to: #19576.