refactor: use lightweight token for lazy menu content#19644
Merged
devversion merged 2 commits intoangular:lightweight-token-optimizationsfrom Jun 17, 2020
Merged
Conversation
31e2809 to
1e933bc
Compare
Angular Material supports lazy content for menus. It does this by querying for the `MatMenuContent` directive in the `MatMenu` component. This is problematic though as it always causes `MatMenuContent` to be retained as its used as actual query predicate token. To solve this, we use a lightweight injection token for querying the lazy content (if present). This optimizes applications using the Angular Material menu without lazy content. Related to: angular#19576.
42bcd2f to
729707f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular Material supports lazy content for menus. It does this
by querying for the
MatMenuContentdirective in theMatMenucomponent. This is problematic though as it always causes
MatMenuContentto be retained as its used as actual query predicatetoken.
To solve this, we use a lightweight injection token for querying
the lazy content (if present). This optimizes applications using
the Angular Material menu without lazy content.
Related to: #19576.