fix(material/menu): close menu when cleared from trigger (#33306)

crisbeto · crisbeto · commit 31904510be85 · 2026-05-28T09:26:22.000+02:00
Fixes that the menu would get stuck in the open state if it's cleared from the trigger while it's open. Fixes #30139. (cherry picked from commit 8b729f3)
diff --git a/src/material/menu/menu-trigger-base.ts b/src/material/menu/menu-trigger-base.ts
@@ -134,6 +134,8 @@ export abstract class MatMenuTriggerBase implements OnDestroy {
           this._parentMaterialMenu.closed.emit(reason);
         }
       });
+    } else {
+      this._destroyMenu();
     }
 
     this._menuItemInstance?._setTriggersSubmenu(this._triggersSubmenu());
diff --git a/src/material/menu/menu.spec.ts b/src/material/menu/menu.spec.ts
@@ -76,7 +76,7 @@ describe('MatMenu', () => {
     window.scroll(0, 0);
   });
 
-  it('should aria-controls the menu panel', () => {
+  it('should set aria-controls on the menu panel', () => {
     const fixture = TestBed.createComponent(SimpleMenu);
     fixture.detectChanges();
     fixture.componentInstance.trigger.openMenu();
@@ -1149,6 +1149,20 @@ describe('MatMenu', () => {
     expect(Math.floor(panelRect.bottom)).toBe(viewportHeight);
   });
 
+  it('should close the menu when it is cleared from the trigger', async () => {
+    const fixture = TestBed.createComponent(SimpleMenu);
+    fixture.detectChanges();
+    fixture.componentInstance.trigger.openMenu();
+    fixture.detectChanges();
+    await wait(200);
+    expect(overlayContainerElement.querySelector('.mat-mdc-menu-panel')).toBeTruthy();
+
+    fixture.componentInstance.trigger.menu = null;
+    fixture.changeDetectorRef.markForCheck();
+    fixture.detectChanges();
+    expect(overlayContainerElement.querySelector('.mat-mdc-menu-panel')).toBeFalsy();
+  });
+
   describe('lazy rendering', () => {
     it('should be able to render the menu content lazily', () => {
       const fixture = TestBed.createComponent(SimpleLazyMenu);

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,8 @@ export abstract class MatMenuTriggerBase implements OnDestroy {`
`134`	`134`	`this._parentMaterialMenu.closed.emit(reason);`
`135`	`135`	`}`
`136`	`136`	`});`
	`137`	`+ } else {`
	`138`	`+ this._destroyMenu();`
`137`	`139`	`}`
`138`	`140`
`139`	`141`	`this._menuItemInstance?._setTriggersSubmenu(this._triggersSubmenu());`