fix(@angular/build): update critical CSS inlining to support autoCsp#29638
Merged
dgp1130 merged 1 commit intoangular:mainfrom Feb 14, 2025
Merged
fix(@angular/build): update critical CSS inlining to support autoCsp#29638dgp1130 merged 1 commit intoangular:mainfrom
autoCsp#29638dgp1130 merged 1 commit intoangular:mainfrom
Conversation
bffc752 to
4dbb4de
Compare
autoCsp to handle inlined critical CSSautoCsp
84366d7 to
c2e79f9
Compare
c2e79f9 to
57a08c9
Compare
83883d9 to
d0e3f12
Compare
This update improves the handling of inlined critical CSS to align with `autoCsp`, ensuring compliance with Content Security Policy (CSP) directives. Previously, inlined styles could trigger CSP violations in certain configurations. With this fix, critical CSS is inlined in a way that maintains security while supporting `autoCsp`. Closes angular#29603
d0e3f12 to
4bac5d8
Compare
dgp1130
approved these changes
Feb 14, 2025
Collaborator
dgp1130
left a comment
There was a problem hiding this comment.
LGTM, do we want to wait for @aaronshim to take a look or just merge this as is? Feels more related to critical CSS than AutoCSP really.
Collaborator
Author
|
@dgp1130 ship it! Indeed it’s mostly around critical css inlining. |
Collaborator
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the handling of inlined critical CSS to align with
autoCsp, ensuring compliance with Content Security Policy (CSP) directives. Previously, inlined styles could trigger CSP violations in certain configurations. With this fix, critical CSS is inlined in a way that maintains security while supportingautoCsp.Closes #29603
//cc @aaronshim