Skip to content

fix(@angular/build): resolve error with extract-i18n builder for libraries#28115

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:error-localize
Jul 29, 2024
Merged

fix(@angular/build): resolve error with extract-i18n builder for libraries#28115
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:error-localize

Conversation

@alan-agius4
Copy link
Collaborator

The extract-i18n builder is only intended to be used with application projects.

Closes #28109

@alan-agius4 alan-agius4 requested a review from dgp1130 July 26, 2024 08:56
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 26, 2024
@alan-agius4 alan-agius4 force-pushed the error-localize branch 2 times, most recently from 94d1aad to 44998e7 Compare July 26, 2024 08:58
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test somewhere that the builder emits this error as expected?

…braries

The `extract-i18n` builder is only intended to be used with application projects.

Closes angular#28109
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 29, 2024
@alan-agius4 alan-agius4 merged commit 0466fb7 into angular:main Jul 29, 2024
@alan-agius4 alan-agius4 deleted the error-localize branch July 29, 2024 07:06
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 18.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path[1] argument must be of type string. Received undefined

2 participants