fix(@angular/cli): add schema.json options to parsed command, also when a version is passed to ng add <package>@<version>#27767
Merged
dgp1130 merged 1 commit intoangular:mainfrom Jun 4, 2024
Conversation
alan-agius4
reviewed
Jun 3, 2024
…when a version is passed to `ng add <package>@<version>` This commit fixes the method `AddCommandModule.getCollectionName()`, so it now returns only the package name, but remove the specified version (if present). Previously, a `@<version>` specified in the const `collectionName` was causing a (silenced) error during the invocation of `workflow.engine.createCollection(collectionName)`, which lead to skipping eventually the invocation of the method `this.addSchemaOptionsToCommand()` in the try/catch block. fixes angular#27766
alan-agius4
approved these changes
Jun 4, 2024
alan-agius4
approved these changes
Jun 4, 2024
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Collaborator
|
The changes were merged into the following branches: main, 18.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the method
AddCommandModule.getCollectionName(), so it now returns only the package name, but remove the specified version (if present).Previously, a
@<version>specified in the constcollectionNamewas causing a (silenced) error during the invocation ofworkflow.engine.createCollection(collectionName), which lead to skipping eventually the invocation of the methodthis.addSchemaOptionsToCommand()in the try/catch block.fixes #27766
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #27766
What is the new behavior?
Does this PR introduce a breaking change?
Other information