Skip to content

fix(@angular-devkit/build-angular): ensure esbuild-based builders exclusively produce ESM output#27431

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:cjs-esbuild
Apr 8, 2024
Merged

fix(@angular-devkit/build-angular): ensure esbuild-based builders exclusively produce ESM output#27431
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:cjs-esbuild

Conversation

@alan-agius4
Copy link
Collaborator

Previously, there were instances where the ESbuilder might incorrectly generate CJS code, leading to runtime errors.

Fixes #27421

…lusively produce ESM output

Previously, there were instances where the ESbuilder might incorrectly generate CJS code, leading to runtime errors.

Fixes angular#27421
@alan-agius4 alan-agius4 requested a review from clydin April 8, 2024 08:40
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release requires: TGP action: review The PR is still awaiting reviews from at least one requested reviewer and removed requires: TGP labels Apr 8, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 8, 2024
@alan-agius4 alan-agius4 merged commit afa76bb into angular:main Apr 8, 2024
@alan-agius4 alan-agius4 deleted the cjs-esbuild branch April 8, 2024 13:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic require of "@angular/platform-browser" is not supported

2 participants