perf(@angular-devkit/build-angular): reduce build times for apps with a large number of components when utilizing esbuild-based builders#27281
Merged
alan-agius4 merged 2 commits intoangular:mainfrom Mar 14, 2024
Conversation
3c90256 to
29d6733
Compare
d9562cf to
380d795
Compare
clydin
approved these changes
Mar 14, 2024
… a large number of components when utilizing esbuild-based builders In this commit, we've optimized the build performance for applications containing a large number of components when using the esbuild-based builder. This optimization entails replacing the spread operator with `Object.assign` when appending to the result metadata in the Angular compiler plugin to avoid creating multiple copies of the object. See: https://bugs.chromium.org/p/v8/issues/detail?id=11536 **Previous Performance**: - Initial compilation: 37 seconds - First incremental build: 20 seconds - Second incremental build: 16 seconds **Updated Performance**: - Initial compilation: 24 seconds - First incremental build: 6 seconds - Second incremental build: 2 seconds Closes angular#27280
This commit removes an unused imported symbol.
380d795 to
1554bf6
Compare
XhmikosR
reviewed
Mar 21, 2024
| if (result.metafile && metafile) { | ||
| result.metafile.inputs = { ...result.metafile.inputs, ...metafile.inputs }; | ||
| result.metafile.outputs = { ...result.metafile.outputs, ...metafile.outputs }; | ||
| // Append the existing object, by appending to it we prevent unnecessary new objections creations with spread |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we've optimized the build performance for applications containing a large number of components when using the esbuild-based builder. This optimization entails replacing the spread operator with
Object.assignwhen appending to the result metadata in the Angular compiler plugin to avoid creating multiple copies of the object.See: https://bugs.chromium.org/p/v8/issues/detail?id=11536
Previous Performance:
Updated Performance:
Closes #27280