Skip to content

fix(@schematics/angular): do not add unnecessary dependency on @angular/ssr during migration#26096

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:universal-migration-dep
Oct 23, 2023
Merged

fix(@schematics/angular): do not add unnecessary dependency on @angular/ssr during migration#26096
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:universal-migration-dep

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Oct 23, 2023

Prior to this change the Universal migration ran and added @angular/ssr even the workspace did not depend on @nguniversal/ packages.

Closes #26083

@alan-agius4 alan-agius4 requested a review from clydin October 23, 2023 08:52
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 23, 2023
@alan-agius4 alan-agius4 force-pushed the universal-migration-dep branch from a3579b1 to 9bfa71e Compare October 23, 2023 08:53
…lar/ssr` during migration

Prior to this change the Universal migration ran and added `@angular/ssr` even the workspace did not depend on `@nguniversal/` packages.

Closes angular#26083
@alan-agius4 alan-agius4 force-pushed the universal-migration-dep branch from 9bfa71e to f1fb7eb Compare October 23, 2023 09:00
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2023
@alan-agius4 alan-agius4 merged commit c07cbd5 into angular:main Oct 23, 2023
@alan-agius4 alan-agius4 deleted the universal-migration-dep branch October 23, 2023 13:17
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

17.0.0 migration unnecessarily adds @angular/ssr

2 participants