feat(@angular-devkit/build-angular): add wildcard option for allowedCommonJsDependencies#26047
Conversation
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Please also include the change https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/tools/webpack/plugins/common-js-usage-warn-plugin.ts and update the description of allowedCommonJsDependencies in the various schema to method the wildcard behaviour.
The commit message is invalid please update the scope, add a body and footer.
feat(@angular-devkit/build-angular): add wildcard option for `allowedCommonJsDependencies`
This commit adds the functionality to that when a wildcard `*` is provided to `allowedCommonJsDependencies` CJS/AMD warnings usages is skipped.
Closes #25784
packages/angular_devkit/build_angular/src/tools/esbuild/commonjs-checker.ts
Outdated
Show resolved
Hide resolved
…CommonJsDependencies` This commit adds the functionality to that when a wildcard `*` is provided to `allowedCommonJsDependencies` CJS/AMD warnings usages is skipped. Closes angular#25784
4822c6e to
a13f2b6
Compare
|
Good point, thanks. I resolved everything and squashed the commits. Ok? |
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution
allowedCommonJsDependencies
allowedCommonJsDependenciesallowedCommonJsDependencies
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
PR Type
What is the current behavior?
The
allowedCommonJsDependenciesproperty suppresses warnings if CJS/AMD modules are used.The developer can then search for alternative dependencies or expand this list.
If there are many affected dependencies that the developer needs to use without alternatives, it’s a lot of effort to constantly maintain this list. It would be helpful if there is an option to allow all dependencies…
Closes #25784
What is the new behavior?
The current behavior remains unchanged, but gives developers the option to allow all CJS/AMD dependencies by using asterisk (
*) as entry inallowedCommonJsDependencies.Does this PR introduce a breaking change?