Skip to content

perf(@angular-devkit/build-angular): reduce rebuilt times when using the scripts option#24715

Merged
angular-robot[bot] merged 1 commit intoangular:mainfrom
alan-agius4:resolver-scripts
Feb 14, 2023
Merged

perf(@angular-devkit/build-angular): reduce rebuilt times when using the scripts option#24715
angular-robot[bot] merged 1 commit intoangular:mainfrom
alan-agius4:resolver-scripts

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 14, 2023

In some cases, using the scripts option caused a lot of DescriptionFileUtils.loadDescriptionFile calls which caused a bottleneck during build times.

The why to this is still unknown, but a workaround is to use the resolver from the Webpack compilation instead of the compiler.

Closes #24634


From @fearghalom

On rebuilds, it knocked ~35secs off the time.

@alan-agius4 alan-agius4 requested a review from clydin February 14, 2023 14:21
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 14, 2023
@alan-agius4 alan-agius4 marked this pull request as ready for review February 14, 2023 14:21
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): reduce rebuilt times when using the scripts option perf(@angular-devkit/build-angular): reduce rebuilt times when using the scripts option Feb 14, 2023
…the `scripts` option

In some cases, using the `scripts` option caused a lot of `DescriptionFileUtils.loadDescriptionFile` calls which caused a bottleneck during build times.

The why to this is still unknown, but a workaround is to use the resolver from the Webpack compilation instead of the compiler.

Closes angular#24634
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 14, 2023
@angular-robot angular-robot bot merged commit 1e52863 into angular:main Feb 14, 2023
@alan-agius4 alan-agius4 deleted the resolver-scripts branch February 14, 2023 15:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng serve Incremental Build Times Increased Massively When Upgrading From Angular v12 -> v15

2 participants