fix(@angular-devkit/build-angular): do not fail compilation when spec pattern does not match#24665
Merged
angular-robot[bot] merged 1 commit intoangular:mainfrom Feb 7, 2023
Merged
Conversation
64c16ca to
17822d9
Compare
… pattern does not match Previously, we failed the compilation when the specified patterns did not match any spec file. This breaks the case were users configure Karma to not fail on empty test suit. Closes angular#24644
17822d9 to
d4376dd
Compare
clydin
approved these changes
Feb 6, 2023
| const { result, logs } = await harness.executeOnce(); | ||
| const { result } = await harness.executeOnce(); | ||
| expect(result?.success).toBeFalse(); | ||
| expect(logs).toContain( |
Member
There was a problem hiding this comment.
Shouldn't the log message should still be here even with the logic change?
Collaborator
Author
There was a problem hiding this comment.
Form my understanding Webpack will print the logs to the console directly.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we failed the compilation when the specified patterns did not match any spec file. This breaks the case were users configure Karma to not fail on empty test suit.
Closes #24644