Skip to content

fix(@angular/cli): catch clause variable is not an Error instance#23645

Merged
alan-agius4 merged 2 commits intoangular:mainfrom
alan-agius4:error-instance-of
Jul 28, 2022
Merged

fix(@angular/cli): catch clause variable is not an Error instance#23645
alan-agius4 merged 2 commits intoangular:mainfrom
alan-agius4:error-instance-of

Conversation

@alan-agius4
Copy link
Collaborator

Errors thrown in RxJs are not instanceof Error and therefore the check will always fail.

Closes #23631

Errors thrown in RxJs are not instanceof Error and therefore the check will always fail.

Closes angular#23631
…rror instance

Errors thrown in RxJs are not instanceof Error and therefore the check will always fail.

Closes angular#23631
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 27, 2022
@alan-agius4 alan-agius4 requested a review from clydin July 27, 2022 11:38
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 27, 2022
@alan-agius4 alan-agius4 merged commit 8fd3e9f into angular:main Jul 28, 2022
@alan-agius4 alan-agius4 deleted the error-instance-of branch July 28, 2022 07:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng generate component - catch clause variable is not an Error instance

2 participants