Skip to content

fix(@angular-devkit/build-angular): exit localized build when CTRL+C is pressed#23457

Merged
clydin merged 1 commit intoangular:mainfrom
alan-agius4:sigint
Jun 28, 2022
Merged

fix(@angular-devkit/build-angular): exit localized build when CTRL+C is pressed#23457
clydin merged 1 commit intoangular:mainfrom
alan-agius4:sigint

Conversation

@alan-agius4
Copy link
Collaborator

When using localization we setup SIGINT signal to delete the temporary directory. In some cases this resulted in delaying the process from exiting a couple of seconds.

Closes #22216

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release 2022Q3 Fixit labels Jun 28, 2022
@alan-agius4 alan-agius4 requested a review from clydin June 28, 2022 13:17
… is pressed

When using localization we setup `SIGINT` signal to delete the temporary directory. In some cases this resulted in delaying the process from exiting a couple of seconds.

Closes angular#22216
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 28, 2022
@clydin clydin merged commit 2b96254 into angular:main Jun 28, 2022
@alan-agius4 alan-agius4 deleted the sigint branch June 28, 2022 14:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular 13 CLI not stopping after ctrl + c

2 participants